Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show spinner when doing quick auth #1346

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Show spinner when doing quick auth #1346

merged 2 commits into from
Apr 18, 2018

Conversation

luisrudge
Copy link
Contributor

fix #1345

lbalmaceda
lbalmaceda reviewed Apr 18, 2018
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please show in a video/gif how this was fixed?

@luisrudge
Copy link
Contributor Author

Before:
before

After:
after

@lbalmaceda lbalmaceda self-requested a review April 18, 2018 21:05
lbalmaceda
lbalmaceda approved these changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@luisrudge luisrudge merged commit 2d5a83e into master Apr 18, 2018
@luisrudge luisrudge deleted the fix-show-spinner-on-quick-auth branch April 18, 2018 21:11
@luisrudge luisrudge added this to the v11.6.0 milestone Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v11.6.0
Development

Successfully merging this pull request may close these issues.

no loading indicator after clicking remembered login
2 participants
@luisrudge @lbalmaceda