New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new type of additionalSignUpField: hidden #1459

Merged

luisrudge merged 8 commits into master from feature/custom-hidden-fields

Aug 8, 2018

Contributor

luisrudge commented Aug 3, 2018 •

edited

Loading

adds a new type (hidden) of custom signup fields:

Hidden field

To specify a hidden field use: type: "hidden". Both the value and name properties are required.

var options = {
 additionalSignUpFields: [{
   type: "hidden",
   name: "signup_code",
   value: "foobar123"
 }]
}


          Add a new type of additionalSignUpField: hidden

ff56a76

luisrudge added the CH: Added label


          Update README.md

c66455d

joshcanhelp reviewed

View reviewed changes

Contributor

joshcanhelp left a comment

A few questions and needs a better description here. Maybe an example of how to add a hidden field and a link to the docs? Also, it looks like you're adding value support to all fields, is that correct? If so, would be good to call that out as well.

src/__tests__/connection/database/index.test.js Outdated

-                describe('for database connection without username required', () => {
-                  const model = getModel('[email protected]', null, false);
+                  describe('for database connection without username required', () => {
+                    const model = getModel('[email protected]', null, false);

Contributor

joshcanhelp Aug 8, 2018

Why not [email protected]?

Contributor Author

luisrudge Aug 8, 2018 •

edited

Loading

just copy/pasting. will change.

src/__tests__/connection/database/index.test.js Outdated

+                      });
+                      expect(modelOutJS.database.additionalSignUpFields).toEqual([
+                        {
+                          name: 'hidden_field',

Contributor

joshcanhelp Aug 8, 2018

Super-minor but this would look nicer if the values were in same order each time:

{
  "type" : "hidden",
  "name" : "hidden_field",
  "value" : "hidden_value",
}

src/__tests__/field/__snapshots__/custom_input.test.jsx.snap

               </div>
               `;
+              exports[`CustomInput when type == hidden renders correctly as a input[type=hidden] 1`] = `
+              <input
+                name="custom_input"

Contributor

joshcanhelp Aug 8, 2018

Same here ... order of attributes

Contributor Author

luisrudge Aug 8, 2018

we can't control how snapshots are rendered

src/connection/database/index.js Outdated

+                    if (type === 'hidden' && !value) {
+                      l.warn(
+                        opts,
+                        'Ignoring an element of `additionalSignUpFields` because it has a "hidden" `type` but does not specify a `value` string'

Contributor

joshcanhelp Aug 8, 2018

Can you add what element is being ignored here? Saying "an element" is vague.

src/connection/database/index.js

@@ @@ -136,7 +136,7 @@ function processDatabaseOptions(opts) { @@
                       prefill = undefined;
                     }
-                    const types = ['select', 'text', 'checkbox'];
+                    const types = ['select', 'text', 'checkbox', 'hidden'];

Contributor

joshcanhelp Aug 8, 2018

Would it be easy to add email, url, and password here? Would be nice to have that built-in browser validation.

Contributor Author

luisrudge Aug 8, 2018

that's another feature request 😬

src/connection/database/index.js Outdated

-                    ? resolveAdditionalSignUpSelectField(r, x)
-                    : resolveAdditionalSignUpTextField(r, x);
+                  const type = x.get('type');
+                  switch (type) {

Contributor

joshcanhelp Aug 8, 2018

How is the checkbox type resolved?

src/connection/database/index.js Outdated

-                  return x.get('type') === 'select'
-                    ? resolveAdditionalSignUpSelectField(r, x)
-                    : resolveAdditionalSignUpTextField(r, x);
+                  const type = x.get('type');

Contributor

joshcanhelp Aug 8, 2018

Why assign a const here if it's only used once?

src/connection/database/index.js Outdated

@@ @@ -475,3 +488,8 @@ function resolveAdditionalSignUpTextField(m, x) { @@
                 return m;
               }
+              function resolveAdditionalSignUpHiddenField(m, x) {
+                const name = x.get('name');

Contributor

joshcanhelp Aug 8, 2018

Why assign a const here if it's only used once? Why not x.get('value')?

luisrudge added 5 commits

August 8, 2018 12:56


          contoso > auth0


          field order

9b92881


          add what element is being ignored

1f09e9b


          remove const

a70fec4


          remove const

7f03ea7

joshcanhelp approved these changes

View reviewed changes


          Merge branch 'master' into feature/custom-hidden-fields

74f2ff0

luisrudge added this to the v11.9.0 milestone

luisrudge merged commit c4ccd93 into master

luisrudge deleted the feature/custom-hidden-fields branch

August 8, 2018 16:12

arvinsim commented Nov 9, 2018

I am glad that I found that this feature exist by digging through this Github repo.

But this isn't documented on the Lock Configuration Page

Could this be added in the additionalSignupFields section?

Contributor Author

luisrudge commented Nov 9, 2018

@arvinsim PR here: auth0/docs#6933

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet