Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aria-describedby on missing ref #1497

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Remove aria-describedby on missing ref #1497

merged 2 commits into from
Oct 23, 2018

Conversation

Splact
Copy link
Contributor

@Splact Splact commented Oct 3, 2018

Remove aria-describedby attr when the reference does not exists into DOM (so when in InputWrap isValid is false and invalidHint is not empty).

I noticed also that in PhoneNumberInput, SelectInput and VcodeInput the error is never shown, this because no invalidHint is passed to InputWrap.

@luisrudge luisrudge added this to the v11.12.0 milestone Oct 23, 2018
@luisrudge luisrudge merged commit d7673a8 into auth0:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisrudge luisrudge luisrudge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v11.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Splact @luisrudge