Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prefill support to Auth0LockPasswordless #1505

Merged
merged 6 commits into from
Oct 17, 2018
Merged

Conversation

luisrudge
Copy link
Contributor

@luisrudge luisrudge commented Oct 11, 2018

The prefill option makes the input text to be automatically filled with the given value. For example

Will initialize the email input with [email protected]

prefill: {
  email: '[email protected]'
}

Will initialize the phone input with 489999999

prefill: {
  phoneNumber: '489999999'
}

This was already supported by Auth0Lock. This PR adds support for the same behavior in Auth0LockPasswordless.

@luisrudge luisrudge changed the title Add passwordless support to prefill [wip] Add passwordless support to prefill Oct 11, 2018
@luisrudge luisrudge changed the title [wip] Add passwordless support to prefill Add passwordless support to prefill Oct 15, 2018
@@ -80,15 +94,6 @@ class Passwordless {
} else {
return passwordlessStarted(m) ? new VcodeScreen() : new SocialOrPhoneNumberLoginScreen();
}

setTimeout(() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was unreachable code

src/engine/passwordless.js Show resolved Hide resolved
src/__tests__/engine/passwordless.test.js Outdated Show resolved Hide resolved
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖

@luisrudge luisrudge merged commit 6d73517 into master Oct 17, 2018
@luisrudge luisrudge modified the milestone: v11.11.0 Oct 17, 2018
@luisrudge luisrudge added this to the v11.12.0 milestone Oct 23, 2018
@luisrudge luisrudge changed the title Add passwordless support to prefill Add prefill support to Auth0LockPasswordless Oct 23, 2018
@stevehobbsdev stevehobbsdev deleted the feature/pwdless-prefill branch January 29, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants