-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prefill support to Auth0LockPasswordless #1505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisrudge
changed the title
Add passwordless support to prefill
[wip] Add passwordless support to prefill
Oct 11, 2018
luisrudge
changed the title
[wip] Add passwordless support to prefill
Add passwordless support to prefill
Oct 15, 2018
luisrudge
commented
Oct 17, 2018
@@ -80,15 +94,6 @@ class Passwordless { | |||
} else { | |||
return passwordlessStarted(m) ? new VcodeScreen() : new SocialOrPhoneNumberLoginScreen(); | |||
} | |||
|
|||
setTimeout(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was unreachable code
lbalmaceda
reviewed
Oct 17, 2018
lbalmaceda
approved these changes
Oct 17, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎖
luisrudge
changed the title
Add passwordless support to prefill
Add prefill support to Auth0LockPasswordless
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
prefill
option makes the input text to be automatically filled with the given value. For exampleWill initialize the email input with
[email protected]
Will initialize the phone input with
489999999
This was already supported by Auth0Lock. This PR adds support for the same behavior in Auth0LockPasswordless.