Fixed missing scroll issue for sign up #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@degrammer you mind doing a couple of manual tests on mobile / chrome / safari? Thanks |
|
@cocojoe Tested and looking good in mobile safari / chrome latest versions, although we may need to perform additional tests in different versions / real devices available in saucelabs. |
luisrudge
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixed CSS issue that was affecting firefox, users can't scroll the page on create account option.
This was initially reported by linuxfoundation
References
Expected behaviour: (Chrome)
Current behaviour: (Firefox)
User can't scroll down in user sign up option.
Testing
See screenshots above in order to test it.