Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Title cropping and password instructions tooltip #1728

Merged
merged 11 commits into from
Sep 20, 2019

Conversation

thisis-Shitanshu
Copy link
Contributor

@thisis-Shitanshu thisis-Shitanshu commented Sep 16, 2019

Changes

Please describe both what is changing and why this is important. Include:

Checklist

@thisis-Shitanshu thisis-Shitanshu requested a review from a team September 16, 2019 12:01
@thisis-Shitanshu
Copy link
Contributor Author

@luisrudge apologies for the delay.
I have fixed all the "design" issues labeled by you, as discussed #1716.
For any modification, please let me know.

README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@luisrudge
Copy link
Contributor

@thisis-Shitanshu Thanks for the PR! 🎉 I'll test this tomorrow, but I just want to give you a heads up: the lock file was entirely updated. Can you rollback that as well? Thanks again!

@thisis-Shitanshu
Copy link
Contributor Author

@luisrudge I have rolled back yarn.lock as you have asked for.

@luisrudge
Copy link
Contributor

@thisis-Shitanshu thank you so much for this PR!

@luisrudge luisrudge merged commit 10582c8 into auth0:master Sep 20, 2019
@thisis-Shitanshu
Copy link
Contributor Author

It was a good opportunity. Thank you @luisrudge
I forgot to refer the issues, to close them directly from this merged PR. They are still showing open in the Issues list.
This PR closes: Closes: #1315, Closes: #1636

@luisrudge luisrudge changed the title PR for all the "design" issues Fix Title cropping and password instructions tooltip Oct 1, 2019
@luisrudge luisrudge added this to the v11.17.3 milestone Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants