fix: Add missing property for finnish translation #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing `error.signUp.social_signup_needs_terms_acception` property that was added in https://github.com/auth0/lock/blame/1766f2259b81b345d11f5b6f371d4132c85f63a7/src/i18n/en.js#L47
|
Google translate reference,
|
joshcanhelp
approved these changes
Oct 15, 2019
There was a problem hiding this comment.
@petetnt - Looks great, thank you for this!
@luisrudge - Assigned to you to merge (or let me know if I should do that for you).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds missing
error.signUp.social_signup_needs_terms_acceptionproperty that was added in #1733 to the finnish localizationReferences
This this blame shows the added line: https://github.com/auth0/lock/blame/1766f2259b81b345d11f5b6f371d4132c85f63a7/src/i18n/en.js#L47
Testing
Fixed by adding it to my own languageDictionary
Checklist