Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hungarian transalation for social_signup_needs_terms_acception #1744

Merged

Conversation

smatyas
Copy link
Contributor

@smatyas smatyas commented Oct 26, 2019

Changes

Added a hungarian translation for social_signup_needs_terms_acception which was introduced in #1733

References

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@smatyas smatyas requested a review from a team October 26, 2019 12:58
@stevehobbsdev stevehobbsdev self-assigned this Oct 28, 2019
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @smatyas, thanks for submitting this PR!

Could you replace the exclamation mark at the end with a period? That way it doesn't feel like it raises alarm and is more consistent with the other translations.

@luisrudge luisrudge merged commit 13f211f into auth0:master Oct 28, 2019
@stevehobbsdev stevehobbsdev added this to the v11.18.1 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants