Reset .auth0-lock-form display to 'initial' for iPhone #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also reset padding on the content element, as `initial` removes this when applied.
luisrudge
approved these changes
Oct 28, 2019
damieng
approved these changes
Oct 28, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reset the
displayproperty on.auth0-lock-formwhen on iPhone. Also reset padding on the content element, asinitialremoves this when applied.This should fix an issue where the form isn't displayed properly when first displayed on the screen, as verified using a sample repo kindly provided by @ajmueller (#1588 (comment)).
Fixes #1588
References
Testing
Tested using the iPhone simulator running the sample repo provided for this issue.
Checklist