Prevent loading overlay from showing when using Sign In With Apple #1779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
changed the title
joshcanhelp
approved these changes
Jan 15, 2020
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Mar 5, 2020
…uth0#1779) * Suppressed Lock overlay for Sign In With Apple connnection * Added tests for container and core/actions
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
…uth0#1779) * Suppressed Lock overlay for Sign In With Apple connnection * Added tests for container and core/actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds the ability to prevent the "loading" overlay from being shown when a user clicks on a social connection to log in. Additionally, it uses this feature to prevent the overlay from being shown when the "Sign In With Apple" connection was used. This is to work around an issue where, if the user elects to sign in using their Apple account and the native "Sign In With Apple" UI is shown and the user cancels it, they would otherwise get stuck because of this overlay.
Testing
To test, add the "Sign In With Apple" social connection to your Auth0 app, invoke Lock, attempt to sign in on an iOS device and then cancel. The user should be able to continue on and select a different connection.
Additional unit test coverage has been added to cater for the new functionality, including implementing a missing test suite for
core/actions.Checklist