Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-1361] Fix missing padding on social buttons #1808

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Feb 18, 2020

Changes

This PR:

  • Removes text-center on the social button text
  • Adds left/right padding

This was missing from the previous update to these buttons.

Preview

image

Testing

Tested manually in the browser.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev requested a review from a team February 18, 2020 09:26
@stevehobbsdev stevehobbsdev self-assigned this Feb 18, 2020
@stevehobbsdev stevehobbsdev merged commit 4b5b04d into master Feb 18, 2020
@stevehobbsdev stevehobbsdev added this to the v11.22.1 milestone Feb 18, 2020
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Mar 5, 2020
davidpatrick pushed a commit to davidpatrick/lock that referenced this pull request Jun 12, 2020
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants