Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Sign in with Apple button background to full black #1811

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Change Sign in with Apple button background to full black #1811

merged 1 commit into from
Feb 20, 2020

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Feb 20, 2020 •
edited
Loading

Changes

This is a design change for compliance with Apple's guidelines. While they don't specifically call out that the button has to be full black, there are concerns that something like this might cause an app to fail. This change is precautionary.

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev added this to the vNext milestone Feb 20, 2020
@stevehobbsdev stevehobbsdev requested a review from a team February 20, 2020 10:58
@stevehobbsdev stevehobbsdev self-assigned this Feb 20, 2020
lbalmaceda
lbalmaceda approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I color-picked the button on their site and looks they are also using pure black. Would be nice to check what is Universal Login doing.

@stevehobbsdev stevehobbsdev merged commit f3c4697 into master Feb 20, 2020
@stevehobbsdev stevehobbsdev deleted the fix/siwa-background branch February 20, 2020 13:43
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Mar 5, 2020
@jfromaniello
Changed background for Apple button to full black (auth0#1811)
e417a6c
davidpatrick pushed a commit to davidpatrick/lock that referenced this pull request Jun 12, 2020
@davidpatrick
Changed background for Apple button to full black (auth0#1811)
eaf6cb4
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Jul 23, 2020
@jfromaniello
Changed background for Apple button to full black (auth0#1811)
ee68a7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees

@stevehobbsdev stevehobbsdev

Labels
design
Projects
None yet
Milestone
v11.22.2
Development

Successfully merging this pull request may close these issues.
2 participants
@stevehobbsdev @lbalmaceda