[SDK-1389] Applied appearance styles for Bootstrap in Safari #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the appearance value is set correctly when Bootstrap is included on the Lock template, which sets `appearance: button`. This breaks the UI.
stevehobbsdev
added
bug
damieng
approved these changes
Mar 3, 2020
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Mar 5, 2020
This makes sure the appearance value is set correctly when Bootstrap is included on the Lock template, which sets `appearance: button`. This breaks the UI.
davidpatrick
pushed a commit
to davidpatrick/lock
that referenced
this pull request
Jun 12, 2020
This makes sure the appearance value is set correctly when Bootstrap is included on the Lock template, which sets `appearance: button`. This breaks the UI.
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
This makes sure the appearance value is set correctly when Bootstrap is included on the Lock template, which sets `appearance: button`. This breaks the UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This makes sure the appearance value is set correctly when Bootstrap is included on the Lock template, which sets
appearance: button. This breaks the UI in Safari, which renders the buttons without a background color.Before
After
References
This originated from an internal service desk ticket.
Testing
This was tested manually by including the Bootstrap CSS on the playground template.
Checklist