Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Azerbaijan language #1828

Merged
merged 2 commits into from
Mar 17, 2020
Merged

add Azerbaijan language #1828

merged 2 commits into from
Mar 17, 2020

Conversation

Haqverdi
Copy link
Contributor

add Azerbaijan language translations

Changes

Please describe both what is changing and why this is important. Include:

  • Classes and methods added, deleted, deprecated, or changed
  • Screenshots of new or changed UI, if applicable
  • A summary of usage if this is a new feature or change to a public API (this should also be added to relevant documentation once released)

References

Please include relevant links supporting this change such as a:

  • support ticket
  • community post
  • StackOverflow post
  • support forum thread

Please note any links that are not publicly accessible.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

add Azerbaijan language translations
@Haqverdi Haqverdi requested a review from a team March 13, 2020 11:29
@stevehobbsdev
Copy link
Contributor

Thanks @Haqverdi for the translations. We're missing 5 keys from this:

az.js -> error.login.invalid_captcha = "The text you entered was incorrect. <br /> Please try again."
az.js -> error.signUp.captcha_required = "Enter the code shown below to finish signing up."
az.js -> error.signUp.social_signup_needs_terms_acception = "Please agree to the Terms of Service below to continue."
az.js -> captchaCodeInputPlaceholder = "Enter the code shown above"
az.js -> captchaMathInputPlaceholder = "Solve the formula shown above"

It won't break anything, they will just display in English if you don't supply them. Let me know if you'd like to add them before I merge the PR.

@Haqverdi
Copy link
Contributor Author

Haqverdi commented Mar 17, 2020

Thanks @Haqverdi for the translations. We're missing 5 keys from this:

az.js -> error.login.invalid_captcha = "The text you entered was incorrect. <br /> Please try again."
az.js -> error.signUp.captcha_required = "Enter the code shown below to finish signing up."
az.js -> error.signUp.social_signup_needs_terms_acception = "Please agree to the Terms of Service below to continue."
az.js -> captchaCodeInputPlaceholder = "Enter the code shown above"
az.js -> captchaMathInputPlaceholder = "Solve the formula shown above"

It won't break anything, they will just display in English if you don't supply them. Let me know if you'd like to add them before I merge the PR.

okay, i will add them, as soon as possible

@Haqverdi
Copy link
Contributor Author

@stevehobbsdev added, check please

@stevehobbsdev
Copy link
Contributor

@Haqverdi Great! Thanks :)

@stevehobbsdev stevehobbsdev merged commit 4531679 into auth0:master Mar 17, 2020
davidpatrick pushed a commit to davidpatrick/lock that referenced this pull request Jun 12, 2020
* add Azerbaijan language

add Azerbaijan language translations

* Update az.js
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Jul 23, 2020
* add Azerbaijan language

add Azerbaijan language translations

* Update az.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants