Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for google recaptcha #1845

Merged
merged 13 commits into from
May 7, 2020
Merged

Add support for google recaptcha #1845

merged 13 commits into from
May 7, 2020

Conversation

kusold
Copy link
Contributor

@kusold kusold commented Apr 13, 2020 •
edited
Loading

Changes

This adds support for Google ReCaptchaV2. There are necessary Auth0 internal changes for this to work as well.

References

https://auth0team.atlassian.net/browse/CAUTH-399

Testing

Reach out to me via Slack.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@kusold kusold marked this pull request as ready for review April 16, 2020 16:01
@kusold kusold requested a review from a team April 16, 2020 16:01
fyockm
fyockm reviewed Apr 16, 2020
View reviewed changes
src/field/captcha/captcha_pane.jsx Show resolved Hide resolved
src/field/captcha/recaptchav2.js Show resolved Hide resolved
src/field/captcha/recaptchav2.js Outdated Show resolved Hide resolved
test/captcha.test.js Outdated Show resolved Hide resolved
test/captcha.test.js Outdated Show resolved Hide resolved
test/captcha.test.js Show resolved Hide resolved
@jfromaniello
Copy link
Member

Looks good to me

@kusold kusold force-pushed the add_support_for_google_recaptcha branch from d5d5d3a to 807537f Compare April 23, 2020 23:44
@kusold kusold force-pushed the add_support_for_google_recaptcha branch from 807537f to b856b9d Compare April 23, 2020 23:48
fyockm
fyockm reviewed Apr 24, 2020
View reviewed changes
test/captcha.test.js Outdated Show resolved Hide resolved
stevehobbsdev
stevehobbsdev reviewed Apr 27, 2020
View reviewed changes
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial pass looks good. Reached out on Slack to ask about:

  • Testing - how can I test this?
  • Do we need to capture anything additional for the developer on the Readme as to how they use it?

Also I recommend accepting the outstanding suggestion about which removes .only from describe.

@kusold @fyockm
Remove .only
f247463 
Co-Authored-By: Drew Fyock <[email protected]>
@kusold kusold force-pushed the add_support_for_google_recaptcha branch 2 times, most recently from a7f3ef0 to d9c2c38 Compare April 30, 2020 01:25
@kusold kusold force-pushed the add_support_for_google_recaptcha branch from d9c2c38 to eefffbb Compare April 30, 2020 01:27
@stevehobbsdev stevehobbsdev self-requested a review May 1, 2020 13:10
@stevehobbsdev stevehobbsdev added this to the vNext milestone May 7, 2020
@stevehobbsdev stevehobbsdev added CH: Added enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature labels May 7, 2020
@stevehobbsdev stevehobbsdev merged commit e8b4cad into auth0:master May 7, 2020
@karlhorky
Copy link
Contributor

Is this a new feature? I guess if it is, it supersedes things like https://community.auth0.com/t/auth0-login-with-googles-recaptcha-v3/18168/3 ?

Would love to see some public documentation on it! (how to use it, what plans it's included in, etc)

@kusold kusold deleted the add_support_for_google_recaptcha branch May 12, 2020 16:23
@kusold
Copy link
Contributor Author

kusold commented May 12, 2020

@karlhorky This is for an Early Access (EA) feature that has a necessary server-side component. EA features are not guaranteed to ever reach General Availability (GA), but are instead intended to gather feedback on a potential feature. If this feature reaches GA, there will be a release announcement along with corresponding documentation.

@karlhorky
Copy link
Contributor

Ah ok, thanks for the background! Is there anywhere we can sign up for Early Access features? Is it the same as Zero To Launch?

@kusold
Copy link
Contributor Author

kusold commented May 12, 2020

@karlhorky If you reach out to your support representative, they should be able to tell you more about the program and if you qualify. Feel free to include a link to this PR for added context.

@karlhorky
Copy link
Contributor

your support representative

Ah, support representative... hm, not sure if I have one of those. I'll open a support inquiry.

davidpatrick pushed a commit to davidpatrick/lock that referenced this pull request Jun 12, 2020
@kusold @jfromaniello
@fyockm @davidpatrick
Add support for google recaptcha (auth0#1845)
49daa21 
* initial support for google recaptcha

* Add tests for Google Recaptcha

* Add unit tests for recaptcha

* Fix recaptcha property

* Remove console.logs

* Reduce timeout in test to minimum.

This is required because we wait to notify of an error.

https://github.com/auth0/lock/blob/a79d7b7061fd78314630808d6b53b7bc21840370/src/core/actions.js#L189

* Simplify return

* Remove .only

Co-Authored-By: Drew Fyock <[email protected]>

* Update provider name to match change in backend

Co-authored-by: José F. Romaniello <[email protected]>
Co-authored-by: Steve Hobbs <[email protected]>
Co-authored-by: Drew Fyock <[email protected]>
jfromaniello added a commit to jfromaniello/auth0-lock that referenced this pull request Jul 23, 2020
@kusold @jfromaniello @fyockm
Add support for google recaptcha (auth0#1845)
e0312c6 
* initial support for google recaptcha

* Add tests for Google Recaptcha

* Add unit tests for recaptcha

* Fix recaptcha property

* Remove console.logs

* Reduce timeout in test to minimum.

This is required because we wait to notify of an error.

https://github.com/auth0/lock/blob/a79d7b7061fd78314630808d6b53b7bc21840370/src/core/actions.js#L189

* Simplify return

* Remove .only

Co-Authored-By: Drew Fyock <[email protected]>

* Update provider name to match change in backend

Co-authored-by: José F. Romaniello <[email protected]>
Co-authored-by: Steve Hobbs <[email protected]>
Co-authored-by: Drew Fyock <[email protected]>
@karlhorky karlhorky mentioned this pull request Jul 24, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda left review comments

@fyockm fyockm fyockm left review comments

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or improvement to the SDK that could not be otherwise categorized as a new feature
Projects
None yet
Milestone
v11.24.0
Development

Successfully merging this pull request may close these issues.
6 participants
@kusold @jfromaniello @karlhorky @stevehobbsdev @fyockm @lbalmaceda