Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Superagent to latest package. #1865

Merged
merged 7 commits into from
Jun 30, 2020

Conversation

thduttonuk
Copy link
Contributor

Changes

Update superagent to the latest package, It looks like its only used when running i18n:translate and is referenced in complete-translations.js

References

This is causing an issue in Babel when running --localize in Angular, angular/angular-cli#17439

@thduttonuk thduttonuk requested a review from a team May 12, 2020 16:22
@thduttonuk thduttonuk changed the title Updatesuperagent Update Superagent to latest package. May 12, 2020
@stevehobbsdev
Copy link
Contributor

Thanks @thduttonuk . Apologies for the delay here - let me get a quick test and come back to you.

Have you confirmed that this change fixes your issue with Babel?

@stevehobbsdev stevehobbsdev added dependencies One or more dependencies are being bumped tiny labels May 21, 2020
@stevehobbsdev stevehobbsdev merged commit 1b8eb0f into auth0:master Jun 30, 2020
@paviad
Copy link

paviad commented Jul 19, 2020

It didn't help...
Still getting this message:

Localized bundle generation failed: C:\MyProjects\hugon\frontend\main-es2015.aa6efc35f07605d883f8.js: Unexpected reserved word 'arguments' (1:1500486)

EDIT I'm sorry the problem is with auth0.js it also uses the old superagent version and also causes this problem.

jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Jul 23, 2020
* Typo fix in username.js

* Update superagent

Co-authored-by: Steve Hobbs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies One or more dependencies are being bumped
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants