Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header height not updated when Lock dialog is closed and reopened #1874

Merged
merged 2 commits into from
May 29, 2020

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented May 26, 2020

Changes

Make sure headerHeight is set whenever the component mounts. So that when the Lock dialog is close and reopened, its header height gets calculated again.

Also, had to handle a couple of lint errors to pass the pre-commit hook

References

Fixes #1870

Testing

Close and reopen the Lock modal, confirm that the header does not obscure the form on the second opening.

Also tested in IE11

  • This change adds unit test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@adamjmcgrath adamjmcgrath requested a review from a team May 26, 2020 09:44
@adamjmcgrath adamjmcgrath merged commit 61c2182 into master May 29, 2020
@stevehobbsdev stevehobbsdev added this to the vNext milestone Jun 5, 2020
@stevehobbsdev stevehobbsdev deleted the fix-header-height branch June 5, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auth0 Lock "Modal" is not showing "Signup" tab when opened from second time onward
3 participants