Add !hostedLoginPage condition to redirect check #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevehobbsdev Looks good. I noticed the branch wasn't tested since the build didn't break. Is there any reason not to add tests for this change? |
|
@lbalmaceda Sorry about that, I had marked the PR as draft while i was adding tests as they somehow did not get included in the commit, then i noticed a problem but didn't have time to fix immediately. The tests are there now but weirdly the build is breaking on Circle (not locally). Let me look into it. |
|
Ok, tests sorted! |
davidpatrick
approved these changes
Jun 2, 2020
davidpatrick
pushed a commit
to davidpatrick/lock
that referenced
this pull request
Jun 12, 2020
* Add !hostedLoginPage condition to redirect check * Add tests for core/web_api * Use global.window instead of window in web_api.test Co-authored-by: Luciano Balmaceda <[email protected]>
jfromaniello
pushed a commit
to jfromaniello/auth0-lock
that referenced
this pull request
Jul 23, 2020
* Add !hostedLoginPage condition to redirect check * Add tests for core/web_api * Use global.window instead of window in web_api.test Co-authored-by: Luciano Balmaceda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR forces popup mode + sso mode for Electron and Cordova apps only when not on the hosted login page. This means that Electron apps where the login page is opened inside the app would not try and do a cross-origin authentication request when using the hosted ULP.
References
Raised by internal ESD.
Testing
Tested and verified through manual testing with a customer using an Electron app.
Checklist