Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-1710] Allow Lock to use connection display name field from client configuration file #1896

Merged
merged 3 commits into from
Jul 9, 2020

Conversation

stevehobbsdev
Copy link
Contributor

Changes

  • a new property added to Lock configuration to allow the use of the
    display_name field that is returned from the client configuration file
  • if display_name has not been configured or is not available, the previous
    logic of using the name or the domain is used

Usage:

var lock = new Auth0Lock('clientId', 'domain', {
  preferConnectionDisplayName: true
});

References

Raised through internal service desk ticket

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev marked this pull request as ready for review July 9, 2020 10:44
@stevehobbsdev stevehobbsdev requested a review from a team July 9, 2020 10:44
@stevehobbsdev stevehobbsdev merged commit 95714a4 into master Jul 9, 2020
@stevehobbsdev stevehobbsdev added this to the vNext milestone Jul 9, 2020
@stevehobbsdev stevehobbsdev mentioned this pull request Jul 9, 2020
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Jul 23, 2020
…t configuration file (auth0#1896)

* Add property and logic to use display_name if available

* Add tests for pulling connection display name wrt config prop

* Update readme with new property documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants