Remove javascript:void(0) from links that do not navigate #1938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes
javascript:void(0)
from those links that do not navigatenatively using the browser, but perform some other action using a JS callback
handler. In most cases, these links were already covered by a call to
preventDefault()
on the event object anyway.The motivation is to stop warnings from React about using
javascript:
URLsfor security reasons. Note that our usage of
javascript:void(0)
does notcause a security issue as there's no chance of malicious content being injected
by a third party, but we have refactored out the links all the same.
References
#1917
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist