-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESD-10361] Fix password strength popup overflow issue #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…popout of container
lbalmaceda
suggested changes
Dec 16, 2020
lbalmaceda
approved these changes
Dec 16, 2020
Merged
This was referenced Mar 2, 2021
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR provides a host of CSS fixes that fix a number of issues, mainly the password strength popup issue:
container. In order to fix this, a host of CSS changes were made, which also fixed the other issues below.
heights
overflow-x: auto
which caused rendering issuesI've also adding some instructions about testing a local Lock build through the ULP.
Screenshots highlight the issue with the password strength popover. Might be hard to see given the background, but the top of the popover is clipped against the top of the Lock widget in the before screenshot.
Before
After
Testing
This was manually tested in all the browsers I can think of, in mobile and desktop view:
Firefox 83 on Windows
Edge 87 on Windows
IE 11 on Windows 10
Chrome on Samsung Galaxy S10
Chrome on Google Pixel 3
Safari on iPhone 11 (iOS 14, simulator)
Safari on iPhone 8 (iOS 12, simulator)
This change adds unit test coverage
This change adds integration test coverage
This change has been tested on the latest version of the platform/language
Checklist