Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade trim version to fix security issue #1960

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

blankg
Copy link
Contributor

@blankg blankg commented Jan 25, 2021

Changes

Please describe both what is changing and why this is important. Include:

upgrade trim to 0.0.3 to resolve security vulnerability found by Snyk security scan:
"this package are vulnerable to Regular Expression Denial of Service (ReDoS) via trim()"

References

Please include relevant links supporting this change such as a:

https://app.snyk.io/vuln/SNYK-JS-TRIM-1017038

Please note any links that are not publicly accessible.

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@blankg blankg requested a review from a team as a code owner January 25, 2021 10:37
@stevehobbsdev
Copy link
Contributor

stevehobbsdev commented Jan 25, 2021

Thanks for the PR @blankg! I see trim is at version 1.0.0 now, just curious: did you try this version and have problems?

@blankg
Copy link
Contributor Author

blankg commented Jan 25, 2021

@stevehobbsdev, didn't see any problems just wasn't sure on upgrading a major version. If it ok with I can change this PR to upgrade to 1.0.0?

@stevehobbsdev
Copy link
Contributor

@blankg Let's go for it 👍

@stevehobbsdev stevehobbsdev changed the title upgrade trim version to fix security issue Upgrade trim version to fix security issue Jan 29, 2021
@stevehobbsdev stevehobbsdev added this to the vNext milestone Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:tiny Tiny review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants