Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: recaptcha enterprise on lockjs #1986

Merged
merged 7 commits into from
Apr 19, 2021
Merged

feat: recaptcha enterprise on lockjs #1986

merged 7 commits into from
Apr 19, 2021

Conversation

akmjenkins
Copy link
Contributor

@akmjenkins akmjenkins commented Apr 15, 2021 •
edited
Loading

Changes

  • Support enterprise recaptcha on lockjs.

References

Corresponding PR on universal login prompts

Testing

No flow changes - allows a captcha provider of recaptcha_enterprise to render a recaptcha widget

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@akmjenkins akmjenkins requested a review from a team as a code owner April 15, 2021 01:54
@akmjenkins akmjenkins mentioned this pull request Apr 15, 2021
Merged
5 tasks
stevehobbsdev
stevehobbsdev requested changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@stevehobbsdev stevehobbsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just thing a couple of the symbols need tightening up.

src/field/captcha/recaptcha.jsx Outdated Show resolved Hide resolved
src/field/captcha/recaptcha.jsx Outdated Show resolved Hide resolved
src/field/captcha/recaptcha.jsx Outdated Show resolved Hide resolved
@stevehobbsdev stevehobbsdev self-requested a review April 19, 2021 10:54
@stevehobbsdev stevehobbsdev added this to the vNext milestone Apr 19, 2021
@stevehobbsdev stevehobbsdev merged commit a30b27e into auth0:master Apr 19, 2021
@akmjenkins akmjenkins mentioned this pull request Apr 21, 2021
Merged
9 tasks
@stevehobbsdev stevehobbsdev mentioned this pull request Apr 26, 2021
Merged
This was referenced Jun 6, 2021
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
review:medium Medium review
Projects
None yet
Milestone
v11.30.0
Development

Successfully merging this pull request may close these issues.
2 participants
@akmjenkins @stevehobbsdev