Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ID attributes to password field + submit button #2072

Merged
merged 2 commits into from
Dec 14, 2021
Merged

Add ID attributes to password field + submit button #2072

merged 2 commits into from
Dec 14, 2021

Conversation

stevehobbsdev
Copy link
Contributor

Changes

This PR adds id attributes to the password input and submit button
components. Other fields had ID attributes to them in #1517, so makes sense to
add them here.

References

Fixes #2067

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev marked this pull request as ready for review December 13, 2021 20:28
@stevehobbsdev stevehobbsdev requested a review from a team as a code owner December 13, 2021 20:28
@stevehobbsdev stevehobbsdev mentioned this pull request Dec 13, 2021
Closed
@stevehobbsdev stevehobbsdev merged commit c692eb6 into master Dec 14, 2021
@stevehobbsdev stevehobbsdev deleted the fix/input-ids branch December 14, 2021 10:20
@stevehobbsdev stevehobbsdev mentioned this pull request Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
review:small Small review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No 'id' attribute on password input or login button
2 participants
@stevehobbsdev @frederikprijck