Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESD-22705] Don't pass function to ConfirmationPane unless closable is enabled #2176

Merged
merged 2 commits into from
Sep 22, 2022

Conversation

ewanharris
Copy link
Contributor

Changes

Don't always provide a function to SuccessPane instead pass the closeHandler variable so that SuccessPane can correctly distinguish whether to show the close buttong

Testing

This change updates the snapshot as closable is false in that test.

In order to test in the playground change closable to false and passwordlessMethod to link in support/index.html

Checklist

@ewanharris ewanharris requested a review from a team as a code owner September 16, 2022 13:23
@ewanharris ewanharris merged commit d69e607 into master Sep 22, 2022
@ewanharris ewanharris deleted the ESD-22705 branch September 22, 2022 09:57
@ewanharris ewanharris mentioned this pull request Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants