[ESD-22705] Don't pass function to ConfirmationPane unless closable is enabled #2176
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Don't always provide a function to
SuccessPane
instead pass thecloseHandler
variable so thatSuccessPane
can correctly distinguish whether to show the close buttongTesting
This change updates the snapshot as
closable
is false in that test.In order to test in the playground change
closable
tofalse
andpasswordlessMethod
tolink
insupport/index.html
Checklist