Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: captcha input dx tweaks #2272

Merged
merged 2 commits into from
Feb 9, 2023
Merged

chore: captcha input dx tweaks #2272

merged 2 commits into from
Feb 9, 2023

Conversation

stevehobbsdev
Copy link
Contributor

@stevehobbsdev stevehobbsdev commented Feb 9, 2023

Changes

This PR provides some tweaks to the Captcha input, mostly for dev experience and my own sanity.

  • Remove mask-type on the refresh icon - the linter always complains about this and they're investigating whether to support it or not. Doesn't appear to affect the icon visually (see screenshot), so it's been removed for now.
  • Rework the function binders to use arrow syntax; VSCode just doesn't support the "::" syntax for function binding and produces syntax errors in my editor, causing formatters and things to not work.
  • Separately, removes IE11 from the BS testing Matrix. These have been verified locally, and the BS runner continues to be unreliable in this area.

image

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev requested a review from a team as a code owner February 9, 2023 11:37
@stevehobbsdev stevehobbsdev changed the title chore: Captcha input tweaks chore: captcha input dx tweaks Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants