Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added default values to the dictionary and warn about missing keys #651

Merged
merged 5 commits into from
Oct 21, 2016
Merged

Added default values to the dictionary and warn about missing keys #651

merged 5 commits into from
Oct 21, 2016

Conversation

glena
Copy link
Contributor

@glena glena commented Oct 18, 2016

  • It will use the en dictionary as a default for missing keys.
  • If there is any missing key, it will throw a warning in the console.

@glena glena added this to the v10.5.0 milestone Oct 18, 2016
@glena glena force-pushed the merge-default-dictionary branch 3 times, most recently from 8837519 to 7c75e61 Compare October 20, 2016 19:16
@hzalaz hzalaz merged commit dbce5cb into master Oct 21, 2016
@hzalaz hzalaz deleted the merge-default-dictionary branch October 21, 2016 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristiandouce cristiandouce cristiandouce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@glena @cristiandouce @hzalaz