Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide first screen title option #745

Merged
merged 6 commits into from
Jan 16, 2017
Merged

Hide first screen title option #745

merged 6 commits into from
Jan 16, 2017

Conversation

glena
Copy link
Contributor

@glena glena commented Dec 6, 2016 •
edited
Loading

Help defining the option name, now is hideFistPageTitle

@hzalaz hzalaz requested a review from beneliflo December 15, 2016 14:38
@glena
Copy link
Contributor Author

glena commented Dec 23, 2016

@beneliflo we need to review the css

@hzalaz hzalaz assigned beneliflo and unassigned beneliflo Dec 28, 2016
beneliflo
beneliflo approved these changes Jan 4, 2017
View reviewed changes
Copy link
Contributor

@beneliflo beneliflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

@glena glena force-pushed the hide-first-title-and-custom-titles branch from e962b9f to 23e1375 Compare January 9, 2017 15:18
@hzalaz hzalaz changed the title hide first title and custom title per page Hide first screen title option Jan 11, 2017
@hzalaz
Copy link
Member

hzalaz commented Jan 11, 2017 •
edited
Loading

@glena not for now but we need to think the flag name and rebase 😄. Maybe hideMainScreenTitle or hideRootTitle

@glena
Copy link
Contributor Author

glena commented Jan 12, 2017 •
edited
Loading

hideMainScreenTitle it is aaaaaand rebased

@glena glena force-pushed the hide-first-title-and-custom-titles branch from 23e1375 to 59a42a4 Compare January 12, 2017 12:28
@hzalaz hzalaz added this to the v10-Next milestone Jan 13, 2017
@glena glena modified the milestones: v10-Next, v10.10.0 Jan 16, 2017
@glena glena force-pushed the hide-first-title-and-custom-titles branch from 59a42a4 to aa531c1 Compare January 16, 2017 13:17
@glena glena merged commit 430d912 into master Jan 16, 2017
@glena glena deleted the hide-first-title-and-custom-titles branch January 16, 2017 13:22
@gene1wood gene1wood mentioned this pull request Aug 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beneliflo beneliflo beneliflo approved these changes

@hzalaz hzalaz hzalaz approved these changes

Assignees

@beneliflo beneliflo

Labels
None yet
Projects
None yet
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@glena @hzalaz @beneliflo