Only set prefill values when client is initialized #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisrudge
changed the title
glena
suggested changes
Feb 3, 2017
src/engine/classic.js
Outdated
| const { email, username } = options.prefill || {}; | ||
| if (typeof email === "string") model = setEmail(model, email); | ||
| if (typeof username === "string") model = setUsername(model, username, "username", false); | ||
| this.prefill = options.prefill; |
There was a problem hiding this comment.
instead of adding state to the engine, I would put the prefill data into the model and get in from there. this way this keeps stateless and dependent only on the model
src/engine/classic.js
Outdated
| const { email, username } = this.prefill || {}; | ||
| if (typeof email === "string") m = setEmail(m, email); | ||
| if (typeof username === "string") m = setUsername(m, username, "username", false); | ||
|
|
||
| return validateAllowedConnections(m); |
There was a problem hiding this comment.
Maybe we should set the email before this, so the connection check runs over the allowed ones
src/core/index.js
Outdated
| @@ -38,11 +38,12 @@ export function setup(id, clientID, domain, options, hookRunner, emitEventFn) { | |||
| hashCleanup: options.hashCleanup === false ? false : true, | |||
| allowedConnections: Immutable.fromJS(options.allowedConnections || []), | |||
| ui: extractUIOptions(id, options), | |||
| defaultADUsernameFromEmailPrefix: options.defaultADUsernameFromEmailPrefix === false ? false : true | |||
| defaultADUsernameFromEmailPrefix: options.defaultADUsernameFromEmailPrefix === false ? false : true, | |||
| prefill: Immutable.fromJS(options.prefill || {}) | |||
There was a problem hiding this comment.
Maybe dont wrap it? if you will end up unwrapping if
glena
approved these changes
Feb 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #854