Empty secret or public key #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,6 +107,9 @@ module.exports.verify = function(jwtString, secretOrPublicKey, options, callback | |||
| return done(new JsonWebTokenError('jwt signature is required')); | |||
| } | |||
|
|
|||
| if (typeof secretOrPublicKey === "undefined" || secretOrPublicKey === null) // secretOrPublicKey can be empty string | |||
There was a problem hiding this comment.
Can't we change this to just:
if (!secretOrPublicKey) {
return done(new JsonWebTokenError('secret or public key must be provided'));
}There was a problem hiding this comment.
@jtwebman I got impression, that key is allowed to have value of '' (empty string).
Seems safer to check even for empty string, updated code.
|
Thank you very much, published as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When secret or key fails to load or is not provided,
verifycan throw error even with callback.Added check for
nullandundefined