Add support for connection_scope in params
#99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many identity providers recommend asking for permissions progressively as per the requirements of your app, rather than all up-front. Auth0 provides an option for requesting scopes for an identity provider with the `connection_scope` parameter. Right now this can only be set statically in the OmniAuth initializer. This makes it hard to progressively request extra scopes. A pattern for adding dynamic parameters to `authorize_params` already exists and is used for `connection` and `prompt`. We can extend this to add support for `connection_scope` too. The values passed to `connection_scope` are often unique to the identity provider and so will only be applied if they are supported by the connection chosen by the user or the `connection` parameter.
lbalmaceda
approved these changes
Apr 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many identity providers recommend asking for permissions progressively
as per the requirements of your app, rather than all up-front.
Auth0 provides an option for requesting scopes for an identity provider
with the
connection_scopeparameter. Right now this can only be setstatically in the OmniAuth initializer.
This makes it hard to progressively request extra scopes.
A pattern for adding dynamic parameters to
authorize_paramsalreadyexists and is used for
connectionandprompt.We can extend this to add support for
connection_scopetoo.The values passed to
connection_scopeare often unique to the identityprovider and so will only be applied if they are supported by the
connection chosen by the user or the
connectionparameter.Testing
Checklist