Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tests run on Travis CI #11

Merged
merged 2 commits into from
Mar 10, 2015

Conversation

dentarg
Copy link
Contributor

@dentarg dentarg commented Mar 10, 2015

I think removing Gemfile.lock will make the tests run (they don't: https://travis-ci.org/auth0/ruby-auth0/builds/53821456)

I removed the constraint on webmock in gemspec because I got the following error trying to run the tests locally. I was using Ruby 2.2.1 then, so I added that to .travis.yml (sorry, I'm on a train, so I couldn't not test with Ruby 2.1.0)

$ bundle exec rake                                                                                                                                                 dentarg@marv ~/src/ruby-auth0
/Users/dentarg/.rubies/ruby-2.2.1/bin/ruby -I/Users/dentarg/.gem/ruby/2.2.1/gems/rspec-core-3.1.7/lib:/Users/dentarg/.gem/ruby/2.2.1/gems/rspec-support-3.1.2/lib /Users/dentarg/.gem/ruby/2.2.1/gems/rspec-core-3.1.7/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb
Coverage report generated for RSpec to /Users/dentarg/src/ruby-auth0/coverage. 0.0 / 0.0 LOC (100.0%) covered.
/Users/dentarg/.gem/ruby/2.2.1/gems/webmock-0.9.1/lib/webmock/adapters/rspec.rb:2:in `require': cannot load such file -- spec (LoadError)
    from /Users/dentarg/.gem/ruby/2.2.1/gems/webmock-0.9.1/lib/webmock/adapters/rspec.rb:2:in `<top (required)>'
    from /Users/dentarg/.gem/ruby/2.2.1/gems/webmock-0.9.1/lib/webmock/rspec.rb:1:in `require'
    from /Users/dentarg/.gem/ruby/2.2.1/gems/webmock-0.9.1/lib/webmock/rspec.rb:1:in `<top (required)>'
    from /Users/dentarg/src/ruby-auth0/spec/spec_helper.rb:9:in `require'
    from /Users/dentarg/src/ruby-auth0/spec/spec_helper.rb:9:in `<top (required)>'
    from /Users/dentarg/src/ruby-auth0/spec/lib/auth0/api/authentication_endpoints_spec.rb:1:in `require'
    from /Users/dentarg/src/ruby-auth0/spec/lib/auth0/api/authentication_endpoints_spec.rb:1:in `<top (required)>'
    from /Users/dentarg/.gem/ruby/2.2.1/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1105:in `load'
    from /Users/dentarg/.gem/ruby/2.2.1/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1105:in `block in load_spec_files'
    from /Users/dentarg/.gem/ruby/2.2.1/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1105:in `each'
    from /Users/dentarg/.gem/ruby/2.2.1/gems/rspec-core-3.1.7/lib/rspec/core/configuration.rb:1105:in `load_spec_files'
    from /Users/dentarg/.gem/ruby/2.2.1/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:96:in `setup'
    from /Users/dentarg/.gem/ruby/2.2.1/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:84:in `run'
    from /Users/dentarg/.gem/ruby/2.2.1/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:69:in `run'
    from /Users/dentarg/.gem/ruby/2.2.1/gems/rspec-core-3.1.7/lib/rspec/core/runner.rb:37:in `invoke'
    from /Users/dentarg/.gem/ruby/2.2.1/gems/rspec-core-3.1.7/exe/rspec:4:in `<main>'
/Users/dentarg/.rubies/ruby-2.2.1/bin/ruby -I/Users/dentarg/.gem/ruby/2.2.1/gems/rspec-core-3.1.7/lib:/Users/dentarg/.gem/ruby/2.2.1/gems/rspec-support-3.1.2/lib /Users/dentarg/.gem/ruby/2.2.1/gems/rspec-core-3.1.7/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb failed

@jfromaniello
Copy link
Member

Is it a good practice to remove ignore Gemspecs on gems?

I think it is, but I am not ruby dev.. in node.js we have something very similar called "shrinkwrap", and we do not put shrinkwraps on modules (gems), but on applications.

@ivanpetroe ?

@dentarg
Copy link
Contributor Author

dentarg commented Mar 10, 2015

Yes, see http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/

Gems should not have Gemfile.lock

jfromaniello added a commit that referenced this pull request Mar 10, 2015
@jfromaniello jfromaniello merged commit 0a2cf2f into auth0:master Mar 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants