Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Client ID to logout_url #118

Merged
merged 3 commits into from
Jul 20, 2018
Merged

Add Client ID to logout_url #118

merged 3 commits into from
Jul 20, 2018

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Jul 11, 2018 •
edited
Loading

  • Add a second parameter to include the Client ID
  • Add a third parameter to do federated
  • Update URL to v2 logout

Closes #81

@joshcanhelp joshcanhelp added this to the v4-Next milestone Jul 11, 2018
@joshcanhelp joshcanhelp requested review from machuga and removed request for machuga July 11, 2018 23:24
@joshcanhelp joshcanhelp requested a review from machuga July 12, 2018 16:00
cocojoe
cocojoe reviewed Jul 20, 2018
View reviewed changes
lib/auth0/api/authentication_endpoints.rb
returnTo: return_to
returnTo: return_to,
client_id: include_client ? @client_id : nil,
federated: federated ? '1' : nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The endpoint doesn't need a value just the param to be present

Copy link
Contributor Author

@joshcanhelp joshcanhelp Jul 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cocojoe - It doesn't, no, but the query parser was removing empty param values. That =1 isn't going to hurt anything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, just checking.

cocojoe
cocojoe approved these changes Jul 20, 2018
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine 😄

@joshcanhelp joshcanhelp merged commit 697eb15 into master Jul 20, 2018
@joshcanhelp joshcanhelp deleted the add-client-id-to-logout branch July 20, 2018 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cocojoe cocojoe cocojoe approved these changes

@machuga machuga Awaiting requested review from machuga

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
v4.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @cocojoe