Add additional parameters for WS-Fed URL #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
reviewed
Jul 25, 2018
| } | ||
| URI::HTTPS.build(host: @domain, path: "/wsfed/#{@client_id}", query: to_query(request_params)) | ||
|
|
||
| url_client_id = @client_id if !request_params[:wtrealm] |
There was a problem hiding this comment.
so wtrealm and client_id are not compatible?
There was a problem hiding this comment.
| request_params = { | ||
| whr: connection | ||
| whr: connection, | ||
| wtrealm: options[:wtrealm], |
There was a problem hiding this comment.
Please add a test that asserts these properties are not being sent in the body when "null" or missing
There was a problem hiding this comment.
This just generates a URL, no HTTP requests
lbalmaceda
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
optionsparameter towsfed_urlmethod + tests