Explicitly require JSON dependency #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module depends on JSON but doesn't load it. This commit makes that dependency explicit so the application doesn't have to load it.
|
Thanks @jgaskins! I want to make sure that's included everywhere so give me just a bit to review. |
|
Thanks @joshcanhelp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module depends on JSON but doesn't load it. This commit makes that dependency explicit so the application doesn't have to load it.
In all fairness, it's pretty likely that the app does load the
jsongem/stdlib (which is why this has been able to go unnoticed), but we should always load our own dependencies. :-)