-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ttl_sec argument to post_email_verification request. #145
Add ttl_sec argument to post_email_verification request. #145
Conversation
Thank you @digitaldawn, I'll take a look as soon as I can! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@digitaldawn - Alright, I read through this and everything looks fine. Tests can be run with this command:
$ bundle exec rake test
But the CI handled it here so you're good to go.
Added a few pieces of feedback here. Otherwise, looks great!
Hi @joshcanhelp, apologies I should have been clearer with the test scenario. I was able to run the tests but they were all failing as it was looking for credentials (and I wasn't sure to get these). |
…nteger. Added specs to ensure this is the case.
I think I've now added the changes you requested :) |
Thanks @digitaldawn! Looks good at first glance here, I'll review as soon as I can and get this merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @digitaldawn
Changes
Add ttl_sec argument to post_email_verification request.
References
The post_email_verification endpoint supports a ttl_sec parameter which this gem does not currently support. See: https://auth0.com/docs/api/management/v2#!/Tickets/post_email_verification
Testing
The tickets spec was adjusted to include the relevant change here. Admittedly this is blind as I couldn't for the life of me figure our how to run the specs. If anyone can point me to some documentation or guide me through this then that would be great - otherwise I assume this is a relatively non-impactful change and shouldn't break anything.
Checklist