Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add refresh token method and unit tests #150

Merged
merged 2 commits into from
Dec 6, 2018

Conversation

joshcanhelp
Copy link
Contributor

Changes

  • Add Auth0::Api::AuthenticationEndpoints.exchange_refresh_token method.
  • Remove requirement for :redirect_uri param in the exchange_auth_code_for_tokensmethod

References

Closes #111

Testing

Also add a test for exchange_auth_code_for_tokens with custom params.

  • This change adds unit test coverage
  • This change adds integration test coverage (currently no integration tests for tokens)
  • This change has been tested on the latest version of Ruby (ruby-2.5.1)

Checklist

  • All existing and new tests complete without errors
  • All active GitHub checks have passed

@joshcanhelp joshcanhelp added this to the v4.6.0 milestone Dec 5, 2018
@joshcanhelp joshcanhelp requested a review from machuga December 5, 2018 18:30
Copy link

@machuga machuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor spacing issue!

grant_type: 'refresh_token',
client_id: client_id,
client_secret: client_secret,
refresh_token: refresh_token
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment is off here. May be easiest to pull them all to 1 space from the colon?

@joshcanhelp joshcanhelp merged commit d5ea0de into master Dec 6, 2018
@joshcanhelp joshcanhelp deleted the add-refresh-token-method branch December 6, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants