Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formal deprecation of 4 auth endpoint methods; rubocop #151

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

joshcanhelp
Copy link
Contributor

Changes

  • Add deprecation notices on the following methods:
    • Auth0::Api::AuthenticationEndpoints.obtain_access_token
    • Auth0::Api::AuthenticationEndpoints.obtain_user_tokens
    • Auth0::Api::AuthenticationEndpoints.login
    • Auth0::Api::AuthenticationEndpoints.user_info
  • Ran rubocop in Auth0::Api::AuthenticationEndpoints and fixed issues

@@ -75,45 +77,7 @@ def exchange_refresh_token(
AccessToken.from_response post('/oauth/token', request_params)
end

# Retrieve an access token.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved down, added deprecation docs

end
end

# Get access and ID tokens using an Authorization Code.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved down, added deprecation docs

}
AccessToken.from_response post('/oauth/token', request_params)
end

# Get access and ID tokens using Resource Owner Password.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved down, added deprecation docs

get('/userinfo', {}, {'Authorization' => "Bearer #{access_token}"})
end

# Return the user information based on the Auth0 access token.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved down, added deprecation docs

Copy link

@machuga machuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lib/auth0/api/authentication_endpoints.rb Show resolved Hide resolved
@joshcanhelp joshcanhelp merged commit 0f3d402 into master Dec 13, 2018
@joshcanhelp joshcanhelp deleted the deprecate-auth-endpoints branch December 13, 2018 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants