-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formal deprecation of 4 auth endpoint methods; rubocop #151
Conversation
@@ -75,45 +77,7 @@ def exchange_refresh_token( | |||
AccessToken.from_response post('/oauth/token', request_params) | |||
end | |||
|
|||
# Retrieve an access token. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved down, added deprecation docs
end | ||
end | ||
|
||
# Get access and ID tokens using an Authorization Code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved down, added deprecation docs
} | ||
AccessToken.from_response post('/oauth/token', request_params) | ||
end | ||
|
||
# Get access and ID tokens using Resource Owner Password. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved down, added deprecation docs
get('/userinfo', {}, {'Authorization' => "Bearer #{access_token}"}) | ||
end | ||
|
||
# Return the user information based on the Auth0 access token. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved down, added deprecation docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Changes
Auth0::Api::AuthenticationEndpoints.obtain_access_token
Auth0::Api::AuthenticationEndpoints.obtain_user_tokens
Auth0::Api::AuthenticationEndpoints.login
Auth0::Api::AuthenticationEndpoints.user_info
rubocop
inAuth0::Api::AuthenticationEndpoints
and fixed issues