More password change params #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the [auth0 docs]: - `mark_email_as_verified` - if true, this marks the user's email as verified after they change their password - `includeEmailInRedirect` - if true, this includes the user's email address as part of the returnUrl Additionally, I reordered the params to match the auth0 documentation. This might be a breaking change, I'm not a proficient-enough rubyist to know. [auth0 docs]: https://auth0.com/docs/api/management/v2#!/Tickets/post_password_change
joshcanhelp
suggested changes
Feb 4, 2019
There was a problem hiding this comment.
Thanks @nhusher! It looks like you added ttl_sec as well? A bit hard to follow the PR with the order changes.
Additionally, I reordered the params to match the auth0 documentation.
In this case, it does not matter (see keyword args), though it does make the PR a little harder to follow.
|
Added some basic sanity checking that endpoint |
joshcanhelp
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the
post_password_changemethod to contain a few new parameters based on the auth0 docs:mark_email_as_verified- if true, this marks the user's email as verified after they change their passwordincludeEmailInRedirect- if true, this includes the user's email address as part of the returnUrlttl_sec- The TTL of the ticketAdditionally, I reordered the params to match the auth0 documentation. This might be a breaking change, I'm not a proficient-enough rubyist to know.
References
Auth0 "Create a password change ticket" documentation
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.
Checklist