Add Gemfile.lock file #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lbalmaceda - Another set of failing tests here. I seem to recall a similar issue when I tried to add the lock file before. I will investigate a bit on my end. |
|
@joshcanhelp thanks! Ping me if you need help. |
joshcanhelp
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR explicitly adds the Gemfile.lock file required for Snyk to report vulnerabilities. Ideally this should run as part of a CI build. I'll migrate this soon to CircleCI.
References
Snyk documentation for Ruby
Testing
You can run the check locally using the Snyk CLI.
snyk testChecklist