-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Management API Guardian enrollments endpoint #182
Add Management API Guardian enrollments endpoint #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomgi Thanks for the contribution. I have some doubts regarding the introduced aliases. Not the naming but the use of them, asked Josh about his opinion. May I ask why you left out the remaining Guardian endpoints? e.g. templates, provider configuration, the PUT of a factor, tickets, etc. Cheers
Thanks for feedback @lbalmaceda To be honest I left out the remaining Guardian endpoints for a purely pragmatic reason - I didn't need them in my project that uses this gem 😅 But that's a fair point, since I'm adding some of the Guardian endpoints anyway, I might as well spend some time to add all of them - I will try to do that later today. |
Hey @lbalmaceda, I've added all the remaining Guardian endpoints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR here @tomgi! A few issues below, minor change, and a question.
Thanks @joshcanhelp, I've applied your suggestions. |
…n_enrollments_endpoint
Changes
Add endpoint for Guardian enrollments API
References
https://auth0.com/docs/api/management/v2#!/Guardian/get_factors
https://auth0.com/docs/api/management/v2#!/Guardian/get_enrollments_by_id
https://auth0.com/docs/api/management/v2#!/Guardian/delete_enrollments_by_id
Testing
Checklist