Fix request timeout

[makoto-matsumoto]

Changes

#170 changed the initialization of the Auth0::Exception class, but Auth0::RequestTimeout was not changed.

References

Testing

• This change adds unit test coverage
• This change adds integration test coverage
• This change has been tested on the latest version of Ruby

Checklist

• I have read the Auth0 general contribution guidelines
• I have read the Auth0 Code of Conduct
• All existing and new tests complete without errors
• Rubocop passes on all added/modified files
• All active GitHub checks have passed

[joshcanhelp]

@makoto-matsumoto - good catch, thank you for this. Is this currently broken when a RequestTimeout is raised or is this just a nice-to-have including the message there? Asking because I'm not sure if this warrants a patch release.

[makoto-matsumoto]

@joshcanhelp
This is currently broken.

lib/auth0/mixins/httpproxy.rb

      rescue RestClient::Exception => e
        case e
        when RestClient::RequestTimeout
          raise Auth0::RequestTimeout
        else

spec/lib/auth0/mixins/httpproxy_spec.rb

  1) Auth0::Mixins::HTTPProxy.get should raise Auth0::RequestTimeout on send http get method
        to path defined through HTTP when RestClient::RequestTimeout received
     Failure/Error: expect { @instance.send(http_method, '/test') }.to raise_error(Auth0::RequestTimeout)

       expected Auth0::RequestTimeout, got #<ArgumentError: wrong number of arguments (given 0, expected 1..2)> with backtrace:
         # ./lib/auth0/exception.rb:7:in `initialize'
         # ./lib/auth0/mixins/httpproxy.rb:71:in `exception'
         # ./lib/auth0/mixins/httpproxy.rb:71:in `raise'
         # ./lib/auth0/mixins/httpproxy.rb:71:in `rescue in call'
         # ./lib/auth0/mixins/httpproxy.rb:60:in `call'
         # ./lib/auth0/mixins/httpproxy.rb:20:in `block (2 levels) in <module:HTTPProxy>'
         # ./spec/lib/auth0/mixins/httpproxy_spec.rb:77:in `block (5 levels) in <top (required)>'
         # ./spec/lib/auth0/mixins/httpproxy_spec.rb:77:in `block (4 levels) in <top (required)>'
     # ./spec/lib/auth0/mixins/httpproxy_spec.rb:77:in `block (4 levels) in <top (required)>'

[joshcanhelp]

Thank you!

[zinosama]

Hi @joshcanhelp could you please do a patch release for this? It's currently broken and has caused some confusion for my team. Thanks a lot!

[joshcanhelp]

@zinosama - Apologies for the delay here! I'll cut a release in the next day or so. Thank you for the reminder 👍