Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing Permissions mixin #196

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Add missing Permissions mixin #196

merged 1 commit into from
Sep 25, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Sep 25, 2019 •
edited
Loading

Changes

  • Add the missing mixin to `lib/auth0/mixins.rb
  • Move all mixin requires to that file and adjust order (aesthetic)

Note for reviewers: You can ignore everything in spec/fixtures/vcr_cassettes, just recorded HTTP interactions.

References

Closes #192

Testing

Adjusted the spec_helper requires to catch missing required files in the future.

  • This change adds integration test coverage
  • This change has been tested on Ruby 2.6.0

@joshcanhelp joshcanhelp requested a review from a team September 25, 2019 16:33
@joshcanhelp joshcanhelp added this to the v4.9.0 milestone Sep 25, 2019
@joshcanhelp joshcanhelp merged commit 857366d into master Sep 25, 2019
@joshcanhelp joshcanhelp deleted the fix-missing-require-for-permissions branch September 25, 2019 17:30
@qortex qortex mentioned this pull request Jan 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
v4.9.0
Development

Successfully merging this pull request may close these issues.

Missing require Permission
2 participants
@joshcanhelp @lbalmaceda