Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rspec deprecation warning #2

Merged
merged 2 commits into from
Sep 23, 2014
Merged

Fix rspec deprecation warning #2

merged 2 commits into from
Sep 23, 2014

Conversation

dentarg
Copy link
Contributor

@dentarg dentarg commented Aug 6, 2014

RSpec::Core::Configuration#color_enabled= is deprecated. Use
RSpec::Core::Configuration#color= instead.

    RSpec::Core::Configuration#color_enabled= is deprecated. Use
    RSpec::Core::Configuration#color= instead.
@dentarg
Copy link
Contributor Author

dentarg commented Aug 6, 2014

This will make it possible to run the tests through rake.

Running the tests (through rake) failed for me, because I had newer rspec installed. I couldn't do bundle exec rake because rake isn't in the gemspec (maybe it should be?).

@dentarg
Copy link
Contributor Author

dentarg commented Sep 16, 2014

Oops, I screwed that up, didn't I.

Edit: Nice, force push saved me.

@dentarg
Copy link
Contributor Author

dentarg commented Sep 16, 2014

@jfromaniello what do you think? merge?

@jfromaniello
Copy link
Member

Sure, but we don't have any test here LOL... Can you help me a little bit, what will be the defacto way to test a library like this in ruby? webmock and factorygirl?

@dentarg
Copy link
Contributor Author

dentarg commented Sep 16, 2014

Hehe...

I think VCR would be a good fit.

@mgonto
Copy link
Contributor

mgonto commented Sep 16, 2014

VCR with RSpec would be good :).


Martin Gontovnikas
Software Engineer
Buenos Aires, Argentina

Twitter: @mgonto (https://twitter.com/mgonto)
Linkedin: http://www.linkedin.com/in/mgonto
Github: https://github.com/mgonto

On Tuesday, 16 de September de 2014 at 11:48, Patrik Ragnarsson wrote:

Hehe...
I think VCR (https://relishapp.com/vcr/vcr/docs) would be a good fit.


Reply to this email directly or view it on GitHub (#2 (comment)).

@dentarg
Copy link
Contributor Author

dentarg commented Sep 23, 2014

@jfromaniello @mgonto so... merge?

@mgonto
Copy link
Contributor

mgonto commented Sep 23, 2014

Yep, merge :).

Thanks!

mgonto added a commit that referenced this pull request Sep 23, 2014
@mgonto mgonto merged commit 066342e into auth0:master Sep 23, 2014
@dentarg dentarg deleted the fix-rspec-deprecation-warning branch April 13, 2015 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants