Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rubocop-rails #200

Merged
merged 1 commit into from
Jan 27, 2020
Merged

add rubocop-rails #200

merged 1 commit into from
Jan 27, 2020

Conversation

tknzk
Copy link
Contributor

@tknzk tknzk commented Jan 1, 2020

Changes

Fix Warning: unrecognized cop Rails found in .rubocop.yml

References

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of Ruby

Checklist

@tknzk tknzk requested a review from a team January 1, 2020 15:51
@joshcanhelp
Copy link
Contributor

@tknzk - Thanks for the PR and apologies for the delay! Will this still run in a non-Rails environment?

@joshcanhelp joshcanhelp requested review from joshcanhelp and removed request for a team January 24, 2020 15:51
@tknzk
Copy link
Contributor Author

tknzk commented Jan 27, 2020

@joshcanhelp thank you for reviewing.

Will this still run in a non-Rails environment?

No problem.

rubocop-rails is RuboCop extension focused on enforcing Rails best practices and coding conventions.
( https://github.com/rubocop-hq/rubocop-rails )

config is https://github.com/auth0/ruby-auth0/blob/master/.rubocop.yml#L2-L3

@joshcanhelp joshcanhelp added this to the v4.10.0 milestone Jan 27, 2020
@joshcanhelp joshcanhelp merged commit a707f0f into auth0:master Jan 27, 2020
@tknzk
Copy link
Contributor Author

tknzk commented Jan 28, 2020

thanks.

@tknzk tknzk deleted the add_rubocop-rails branch January 28, 2020 01:42
@Widcket Widcket mentioned this pull request Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants