Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing to_json #212

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Fix missing to_json #212

merged 1 commit into from
Jun 18, 2020

Conversation

qortex
Copy link
Contributor

@qortex qortex commented Apr 14, 2020

Fixes #193

Tests are widely not working when running rake test and need massive rework (from what I can tell, there are missing VCR Cassettes calls). Or there is some config I miss (161 failures). So I couldn't have them pass.

Please let me know if there's a trick.

@qortex qortex requested a review from a team April 14, 2020 08:28
This was referenced Apr 14, 2020
Closed
Closed
@joshcanhelp joshcanhelp removed their request for review April 23, 2020 16:58
@stevehobbsdev
Copy link
Contributor

@qortex Thanks for raising this and sorry for the lack of response here. We've just brought in #218 which updates information around testing. It also preconfigures the test run with the environment variables that you need in order to have the integration tests pass.

If you update this PR branch with what is in master now, you should be able to run the tests ok.

@qortex
Copy link
Contributor Author

qortex commented May 5, 2020

Ok cool, thanks for the update. I'll take a look in the upcoming days.

@qortex
Copy link
Contributor Author

qortex commented May 24, 2020 •
edited
Loading

Looks like the tests now pass :) (was going to take a look, but it looks the fixes on the test framework fixed that also!)

So I guess merging can now be safely done?

@Widcket
Copy link
Contributor

Widcket commented Jun 17, 2020

Hi @qortex, apologies for the delay. Can you please update with the latest changes on master?

@qortex
Copy link
Contributor Author

qortex commented Jun 18, 2020

Alright just did the rebase. Thanks for moving this forward!

@Widcket Widcket merged commit 250b273 into auth0:master Jun 18, 2020
@Widcket Widcket added this to the v4.13.0 milestone Jun 18, 2020
@Widcket Widcket mentioned this pull request Jun 18, 2020
Merged
@Widcket
Copy link
Contributor

Widcket commented Jun 19, 2020

This is out now on 4.13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Widcket Widcket Widcket approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
v4.13.0
Development

Successfully merging this pull request may close these issues.

Missing to_json for delete_with_body
3 participants
@qortex @stevehobbsdev @Widcket