Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for name_filter parameter [SDK-1607] #214

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Added support for name_filter parameter [SDK-1607] #214

merged 1 commit into from
Apr 23, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Apr 23, 2020 •
edited
Loading

Changes

This PR adds support for the name_filter parameter on the get_roles endpoint to filter roles by name.

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of Ruby

Checklist

@Widcket Widcket requested a review from a team April 23, 2020 11:07
@Widcket Widcket added the tiny label Apr 23, 2020
@Widcket Widcket added this to the v4.10.0 milestone Apr 23, 2020
@joshcanhelp joshcanhelp removed their request for review April 23, 2020 16:58
@Widcket Widcket merged commit 143fcbd into master Apr 23, 2020
@Widcket Widcket deleted the feature/filter-roles-by-name branch April 23, 2020 18:17
@Widcket Widcket mentioned this pull request Apr 24, 2020
Merged
@stevehobbsdev stevehobbsdev mentioned this pull request May 1, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
v4.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Widcket @lbalmaceda