Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OIDC compliance [SDK-987] #225

Merged
merged 24 commits into from
Jun 10, 2020
Merged

Improve OIDC compliance [SDK-987] #225

merged 24 commits into from
Jun 10, 2020

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Jun 10, 2020

Changes

This update improves the SDK support for OpenID Connect. In particular, it modifies the sign in verification phase by substituting backchannel based checks with id_token validation.

This PR aggregates a series of previously reviewed and approved PRs:

Public surface area

Additions
  • A new public method in Auth0::Client called validate_id_token that performs ID Token validation.
  • Auth0::Algorithm::HS256 and Auth0::Algorithm::RS256, classes that represent the signing algorithms and encapsulate the logic to obtain the respective secret/public keys.
  • A new exception Auth0::InvalidIdToken.
Changes

None.

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of Ruby

Checklist

@Widcket Widcket added this to the v4.12.0 milestone Jun 10, 2020
@Widcket Widcket requested a review from a team June 10, 2020 21:17
@Widcket Widcket merged commit 240416c into master Jun 10, 2020
@Widcket Widcket deleted the feature/idtv branch June 10, 2020 23:23
@Widcket Widcket mentioned this pull request Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants