Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressable dependency #247

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Addressable dependency #247

merged 1 commit into from
Oct 21, 2020

Conversation

davidpatrick
Copy link
Contributor

Changes

Addressable dependency was only avail in development environments through webmock. It should be included in the Gemfile

@davidpatrick davidpatrick requested a review from a team October 21, 2020 19:13
stevehobbsdev
stevehobbsdev previously approved these changes Oct 21, 2020
View reviewed changes
@rally25rs
Copy link

Should addressable be added to the gemspec file too? IIRC bundler will refer to that, not the Gemfile, when adding ruby-auth0 as a dependency to other consumer projects

@rally25rs
Copy link

Addressable dependency was only avail in development environments through webmock

That is funny. I was wondering how the CI passed, and so did ours after upgrading the gem. It only failed once we pushed it to a prod-like environment... but we use webmock too 😆

@davidpatrick
Copy link
Contributor Author

That is funny. I was wondering how the CI passed, and so did ours after upgrading the gem. It only failed once we pushed it to a prod-like environment... but we use webmock too 😆

😅 thanks for catching it @rally25rs really appreciate it

rally25rs
rally25rs previously approved these changes Oct 21, 2020
View reviewed changes
Copy link

@rally25rs rally25rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should work. Thanks for the super fast turnaround! 👍 Once a new gem version is published I'll give it a test in the same project & environment where we found the issue.

@davidpatrick
Copy link
Contributor Author

I moved it completely into gemspec. I will aim to cut a release for 4.17.1 here within the hour

@davidpatrick davidpatrick requested a review from a team October 21, 2020 19:50
jimmyjames
jimmyjames approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidpatrick davidpatrick merged commit 111d734 into master Oct 21, 2020
@davidpatrick davidpatrick deleted the addressable branch October 21, 2020 19:51
@davidpatrick davidpatrick mentioned this pull request Oct 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmyjames jimmyjames jimmyjames approved these changes

@rally25rs rally25rs rally25rs left review comments

@stevehobbsdev stevehobbsdev Awaiting requested review from stevehobbsdev

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidpatrick @rally25rs @jimmyjames @stevehobbsdev