Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add name param to connections api #260

Merged
merged 1 commit into from
Feb 23, 2021
Merged

add name param to connections api #260

merged 1 commit into from
Feb 23, 2021

Conversation

QWYNG
Copy link
Contributor

@QWYNG QWYNG commented Feb 11, 2021 •
edited
Loading

Hi, Thank you for Great Gem.

Changes

I added name param to Connections api because I couldn't pass the name parameter even though it exists.

References

https://auth0.com/docs/api/management/v2#!/Connections/get_connections

Testing

  • This change adds unit test coverage

Checklist

Rubocop was failing before the change...

@QWYNG QWYNG changed the title add name params to connections add name param to connections api Feb 11, 2021
@QWYNG QWYNG marked this pull request as ready for review February 11, 2021 02:10
@QWYNG QWYNG requested a review from a team as a code owner February 11, 2021 02:10
@davidpatrick davidpatrick added this to the v5ne milestone Feb 23, 2021
@davidpatrick davidpatrick merged commit 3cd1df0 into auth0:master Feb 23, 2021
@davidpatrick davidpatrick mentioned this pull request Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidpatrick davidpatrick davidpatrick approved these changes

Assignees
No one assigned
Labels
CH: Added
Projects
None yet
Milestone
v5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@QWYNG @davidpatrick